Compilation fix: Remove redefinition for std::is_same_v() - #8369
Merged
Conversation
Contributor
Author
|
Failure seems transient, and unrelated to the change:
|
jrhemstad
approved these changes
May 26, 2021
ramakrishnap-nv
approved these changes
May 26, 2021
ramakrishnap-nv
left a comment
Contributor
There was a problem hiding this comment.
Looks good, update copyright.
Contributor
|
@gpucibot merge |
Contributor
|
rerun tests |
Contributor
Author
Argh! Sorry I missed the copyright. Any objection to my pushing a fix to this? |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8369 +/- ##
===============================================
Coverage ? 82.86%
===============================================
Files ? 106
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14811
Misses ? 3063
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks for the reviews, all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
nvcc-11.2+gcc-10.2, one sees the following compilation errors intype_list_tests.cpp:I'm not sure why this doesn't turn up with
gcc-9, even though we're using--std=c++17on both.This commit removes the redefinition of
is_same_v().