Skip to content

Replace local copyright check with pre-commit-hooks verify-copyright - #5732

Merged
rapids-bot[bot] merged 12 commits into
NVIDIA:branch-24.04from
KyleFromNVIDIA:verify-copyright
Mar 12, 2024
Merged

Replace local copyright check with pre-commit-hooks verify-copyright#5732
rapids-bot[bot] merged 12 commits into
NVIDIA:branch-24.04from
KyleFromNVIDIA:verify-copyright

Conversation

@KyleFromNVIDIA

@KyleFromNVIDIA KyleFromNVIDIA commented Jan 29, 2024

Copy link
Copy Markdown
Member

The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30

And get all existing files up to date with --batch.
@KyleFromNVIDIA
KyleFromNVIDIA requested review from a team as code owners January 29, 2024 16:20
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ ci labels Jan 29, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 29, 2024
@github-actions github-actions Bot removed conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ ci labels Jan 30, 2024
@github-actions github-actions Bot added the ci label Jan 30, 2024
@bdice
bdice removed request for a team March 11, 2024 21:14
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit c52ca52 into NVIDIA:branch-24.04 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - In Progress Currenty a work in progress ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants