Automate C++ include file grouping and ordering using clang-format - #5787
Merged
rapids-bot[bot] merged 2 commits intoFeb 29, 2024
Merged
Conversation
bdice
added
improvement
dantegd
approved these changes
Feb 28, 2024
dantegd
left a comment
dantegd
left a comment
Contributor
There was a problem hiding this comment.
Rules lgtm. If we add other RAPIDS C++ libraries in the future we'll add them, but for now those seem well covered.
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uses the
IncludeCategoriessettings in.clang-formatto automate include ordering and grouping and to make include ordering more consistent with the rest of RAPIDS. For discussion, see NVIDIA/cudf#15063. This PR uses a similar set of header grouping categories used in that PR, adapted for cuML.One purpose of this is to make it easier to automate injection of a header change with an upcoming RMM refactoring (and in the future).
The header reordering in this PR uncovered multiple places where headers were not included where they are used. Most commonly this was a missing
#include <raft/core/handle.hpp>Closes #5779