feat(nvca): configure Secret-backed workload transport trust - #655
Merged
mikeyrcamp merged 1 commit intoAug 4, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
mikeyrcamp
force-pushed
the
agent/secret-backed-workload-transport-trust
branch
from
August 4, 2026 14:39
162c48a to
5ee5d78
Compare
mikeyrcamp
changed the base branch from
main
to
release-src/compute-plane-services/nvca/v3.1
August 4, 2026 14:39
mikeyrcamp
force-pushed
the
agent/secret-backed-workload-transport-trust
branch
from
August 4, 2026 16:19
1550bd0 to
1af8972
Compare
mikeyrcamp
marked this pull request as ready for review
August 4, 2026 16:20
mikeyrcamp
force-pushed
the
agent/secret-backed-workload-transport-trust
branch
6 times, most recently
from
August 4, 2026 17:09
5825571 to
faa9f7f
Compare
Max-NV
self-requested a review
August 4, 2026 17:23
Max-NV
approved these changes
Aug 4, 2026
kristinapathak
approved these changes
Aug 4, 2026
This was referenced Aug 4, 2026
mikeyrcamp
force-pushed
the
agent/secret-backed-workload-transport-trust
branch
2 times, most recently
from
August 4, 2026 20:25
3c411c2 to
1193cc1
Compare
mikeyrcamp
force-pushed
the
agent/secret-backed-workload-transport-trust
branch
from
August 4, 2026 20:28
1193cc1 to
e075d7d
Compare
mikeyrcamp
enabled auto-merge (squash)
August 4, 2026 20:31
mikeyrcamp
merged commit Aug 4, 2026
334aaa9
into
release-src/compute-plane-services/nvca/v3.1
31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Managed NVCA deployments need a chart-owned, rotation-aware way to supply a workload transport CA bundle from a Kubernetes Secret. The raw agent configuration overlay is not an appropriate configuration surface for this managed trust source.
What changed
operatorConfig.workload.transportTLSHelm values and the chart-ownednvca-operator-configConfigMap.agentConfig.mergeConfigand preserved the last-good generated agent configuration on invalid input.nvcaconfig.Configmapping innvca_config_mapper.go, with setup and rollout comparison sharing one desired agent-ConfigMap builder.Customer Release Notes
Managed NVCA Operator deployments can configure workload transport trust from a Kubernetes Secret.
Usage
Configure a release-namespace Secret such as
nvcf-trust:The Secret is not mounted into the operator and no CRD or RBAC changes are required.
Testing
golangci-lintwith 0 issuesVersioning
Chart defaults remain pinned to
3.0.4. The Kind validation side-loaded the locally built operator under the cluster's existing3.1.0image reference.References
Relates to #50 and #658.
Related Pull Requests
None.
Dependencies
None.