feat(nvca): configure Secret-backed workload transport trust - #672
Draft
mikeyrcamp wants to merge 1 commit into
Draft
feat(nvca): configure Secret-backed workload transport trust#672mikeyrcamp wants to merge 1 commit into
mikeyrcamp wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #655 landed on the NVCA 3.1 release branch, but the same Secret-backed workload transport trust support is not present on
main. Bringing the change forward keeps the development and release lines aligned and gives managed NVCA deployments a chart-owned, rotation-aware trust source.What changed
main.operatorConfig.workload.transportTLSvalues and the chart-ownednvca-operator-configConfigMap to both NVCA Operator chart copies.main.Customer Release Notes
Managed NVCA Operator deployments can configure workload transport trust from a Kubernetes Secret.
Plan Summary
The chart adds an operator configuration ConfigMap with empty, backward-compatible defaults. When configured, the operator reads an existing release-namespace Secret. The change adds no CRD fields, Secret mounts, RBAC permissions, or new third-party dependencies.
Usage
Configure a release-namespace Secret such as
nvcf-trust:Testing
Passed:
git diff --check origin/main...HEADbash src/compute-plane-services/nvca/scripts/lint_helm.shhelm lint --strict deploy/helm/nvca-operator/nvca-operator --set ngcConfig.serviceKey=fakekeytemplates/operator-config-cm.yamlThe unfiltered Bazel target compiled successfully, but its local macOS run stops in the pre-existing
TestAgenthelper becausego-mpatchcannot patchos.Exiton this host. The PR-specific filtered tests pass. No additional manual QA is needed for this cherry-pick; PR #655 includes the original Kind integration validation, and Linux CI will run the full required suite.Notes
The source change applied cleanly except for
pkg/operator/reconcile/BUILD.bazel, wheremainuses monorepo-qualified Bazel labels. The resolution retains all currentmainentries and adds only PR #655's new source files, tests, andinternal/transporttlsdependency.References
Relates to #658.
Related Pull Requests
Dependencies
None. No license review or NOTICE update is required.