Events: blocks single and list #653
Conversation
|
Preview deployment: https://events-blocks.preview.avy-fx.org |
src/blocks/BlogList/Component.tsx
Outdated
|
|
||
| return ( | ||
| <div className={cn(wrapInContainer && bgColorClass)}> | ||
| <div className={cn(bgColorClass && `${bgColorClass}`)}> |
There was a problem hiding this comment.
Well, there's only space to show the background color if you're wrapping the component in a container. So I actually think we should keep this, right?
There was a problem hiding this comment.
we can keep wrapInContainer as the logic but that wasnt the problem here. It was just evaluating to whatever the boolean of wrapInContainer && bgColorClass was rather than assigning bgColorClass as a string. I have a follow up issue in #654
It seems like more work to remove them into a separate PR. Since in #658 removing subtypes is necessary, lets just resolve conflicts there (which hopefully will not be too difficult) |
|
I changed my mind - I will remove subtype in any of these files |
Description
Updates event blocks
Related Issues
Fixes #245
Key Changes
include save draft button anddefault time of 800msScreenshots / Demo
Migration Explanation
yes but in #635
Future enhancements / Questions