-
Notifications
You must be signed in to change notification settings - Fork 1
A3 Providers and Courses #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d management routes
…sn't have explicit read permission from a role since those collections have public read
…missions not _any_ permissions
… user has readOnly access + allowing globals to be selected for global role rules
…manager support in access function + minor field tweaks
…nd provider managers
…providers listing page
… with different blocks + updating some access and filter functions
…to see their own user
… invite action + renaming variables in provider application action
… of course types badges on provider cards
|
Preview deployment: https://a3-courses.preview.avy-fx.org |
…l with email field fallback + updated email templates
rchlfryn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a very high level look at this. The review is mostly syntactically focused, but I did pull down everything and look at it. There are 2 things I think we should consider:
- Can we hide the docs or change the link on the dashboard?
- I really think we should do an events migration before merging this in and then another one for A3 events. I am worried we will miss something or had a bad migration.. Thoughts?
We have public A3 provider/courses docs there too so it feels appropriate to me. Thoughts?
Since we're only adding things in all of these, I personally don't have any immediate concerns with doing one big migration for the Since this is getting merged into |
rchlfryn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have public A3 provider/courses docs there too so it feels appropriate to me. Thoughts?
Maybe we just link to the A3 page? I think either way we need to build out our docs for A3 and maybe we can just wait to change it then.
Since this is getting merged into events it logically makes sense to me to have a single migration for events -> main as well.
I did a draft PR of a migration to see how we were doing, and I think we are okay to wait.
|
FWIW I think it's okay to have A3 documentation in the general Avy documentation. |
Description
A3 provider, user, and course management in the admin panel.
Related Issues
Resolves #331
Key Changes
Main changes:
/docs/decisions/012-non-rbac-access-patterns.md)course-by-external-provideras an event type in favor of the Courses collectionanyas an option)User | ClientUserand check for specific permission (see changes under/utilities/rbac)/docs/decisions/012-non-rbac-access-patterns.mdMisc. small changes:
_status= published filter to /events/[slug] generateStaticParamsScreenshots / Demo
Migration Explanation
Will add migration in #635
Future enhancements / Questions
The actual embeds will be in a future PR.