Fix demoui smoother buttons being unreactive#1842
Merged
Rainyan merged 3 commits intoNeotokyoRebuild:masterfrom Mar 17, 2026
Merged
Fix demoui smoother buttons being unreactive#1842Rainyan merged 3 commits intoNeotokyoRebuild:masterfrom
Rainyan merged 3 commits intoNeotokyoRebuild:masterfrom
Conversation
sunzenshen
reviewed
Mar 15, 2026
sunzenshen
previously approved these changes
Mar 15, 2026
Rainyan
force-pushed
the
bug/demosmoother-btn
branch
from
1ef0d7c to
d73d34b
Compare
Rainyan
force-pushed
the
bug/demosmoother-btn
branch
from
afca445 to
31678e2
Compare
sunzenshen
approved these changes
Mar 16, 2026
Contributor
|
on an adjacent topic I wonder if the drive button is broken too. I seem to remember it working like described here where the button is pressed and held, and the player can move around and rotate the camera while the button is held, but currently in nt;re you have to press it to toggle it, release the left mouse button and then press and hold the button again, and only then you can move the camera around. |
AdamTadeusz
approved these changes
Mar 16, 2026
Collaborator
Author
Hmm, I'm too unfamiliar with how the tool is supposed to work but it's possible. Should probably by filed as its own bug with repro steps. |
AdamTadeusz
pushed a commit
to AdamTadeusz/neo
that referenced
this pull request
Mar 19, 2026
* Fix demoui smoother buttons being unreactive * Fix wrong budget group * Refactor Improve code readability
AdamTadeusz
added a commit
that referenced
this pull request
Mar 19, 2026
* Fix demoui smoother buttons being unreactive (#1842) * Fix demoui smoother buttons being unreactive * Fix wrong budget group * Refactor Improve code readability * Server side second auto record command (#1855) * working * fix * delay game_end to end of round * not every comp game should necessarily be recorded * rainfix * Fix spec_next/prev not skipping dead players (#1856) Fix a case where in server demos, spec_next/spec_prev does not correctly skip dead players. * DebugDrawLine grenade trails for spectators and practicing (#1852) * working using debugdralines * clamp and float and stuff * Fix env_sun being hidden when under the centre of view (#1839) * Changing cl_neo_squad_hud_avatar_size updates star texture sizes immediately, also cl_neo_hud_centre convars (#1829) * init * also solve the woldpos marker centre sizes not updating automatically * le epic linux fail * maybe inline breaking it * center -> centre, GetFloat, f * HLTV Changes for a smoother demo watching experience (#1845) * init * cl_observercrosshair is only for roaming observer crosshair * makes most of the new spectate commands work in hltv * fix beacons too * view offsets, userid to entindex properly * neobotmanager ignore sourcetv, fix rest spectate commands * crosshair assert when spectating dead players * float, call spectateChecks function * gpGlobals->maxClients * nits plus quick fixes plus viewmodel is really dark in stvdemos which i only now noticed * don't move lighting origin of weapons attached to players * should probably define this string somewhere else at this point * revert changes to hud_crosshair trying to be smart about cl_observercrosshair * Update src/game/shared/neo/neo_gamerules.cpp Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com> --------- Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com> --------- Co-authored-by: Rainyan <Rainyan@users.noreply.github.com> Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the
demouidemo smoother's dropdown buttons in the legacy VGUI not responding to mouse clicks, making the smoother unusable.If this gets refactored in the future, then
neo/src/game/client/mp3player.cpp
Lines 889 to 891 in 36087ff
Toolchain
Linked Issues