Fix spec_next/prev not skipping dead players in demos#1856
Merged
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom Mar 17, 2026
Merged
Fix spec_next/prev not skipping dead players in demos#1856Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom
Conversation
AdamTadeusz
approved these changes
Mar 17, 2026
Agiel
approved these changes
Mar 17, 2026
AdamTadeusz
pushed a commit
to AdamTadeusz/neo
that referenced
this pull request
Mar 19, 2026
Fix a case where in server demos, spec_next/spec_prev does not correctly skip dead players.
AdamTadeusz
added a commit
that referenced
this pull request
Mar 19, 2026
* Fix demoui smoother buttons being unreactive (#1842) * Fix demoui smoother buttons being unreactive * Fix wrong budget group * Refactor Improve code readability * Server side second auto record command (#1855) * working * fix * delay game_end to end of round * not every comp game should necessarily be recorded * rainfix * Fix spec_next/prev not skipping dead players (#1856) Fix a case where in server demos, spec_next/spec_prev does not correctly skip dead players. * DebugDrawLine grenade trails for spectators and practicing (#1852) * working using debugdralines * clamp and float and stuff * Fix env_sun being hidden when under the centre of view (#1839) * Changing cl_neo_squad_hud_avatar_size updates star texture sizes immediately, also cl_neo_hud_centre convars (#1829) * init * also solve the woldpos marker centre sizes not updating automatically * le epic linux fail * maybe inline breaking it * center -> centre, GetFloat, f * HLTV Changes for a smoother demo watching experience (#1845) * init * cl_observercrosshair is only for roaming observer crosshair * makes most of the new spectate commands work in hltv * fix beacons too * view offsets, userid to entindex properly * neobotmanager ignore sourcetv, fix rest spectate commands * crosshair assert when spectating dead players * float, call spectateChecks function * gpGlobals->maxClients * nits plus quick fixes plus viewmodel is really dark in stvdemos which i only now noticed * don't move lighting origin of weapons attached to players * should probably define this string somewhere else at this point * revert changes to hud_crosshair trying to be smart about cl_observercrosshair * Update src/game/shared/neo/neo_gamerules.cpp Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com> --------- Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com> --------- Co-authored-by: Rainyan <Rainyan@users.noreply.github.com> Co-authored-by: DESTROYGIRL <toddlodyte44@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a case where in server demos, spec_next/spec_prev does not correctly skip dead players.
The current behaviour is technically parity, but the beacons overlay tool we've been using for OGNT demo casts has a patch to fix this, so I guess by a loose definition this would be plugin-parity.
Steps to reproduce
Then, while the demo is playing, pause once there are some dead bots in the field and try going through the player list with mouse1 or mouse2.
What happens
Some of the dead players are being spectated in chase cam
What should happen
The dead players are skipped
Toolchain
Linked Issues