Conversation
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 65 65
Lines 5907 5919 +12
=========================================
+ Hits 5907 5919 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Just some coverage issues, you can take a look deeply if you look at here. Very well done work! Thanks for your contributions! |
|
I added a test that fails when using the default client implementation and so by extension the default retry mechanism. Coverage should be ok now. Test time is now at Thanks for your message. It looks like an exciting project. I'll definitely contribute more. |
tshakalekholoane
left a comment
There was a problem hiding this comment.
See comments. Otherwise great work! We appreciate your contribution.
|
Thanks for the review @tshakalekholoane. I also ended up extracting query url and fixing the error formatting in the handlers. |
|
Awesome, @v4lproik! Just update the |
Resolves #256
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??