feat: Enable zstd level 1 compression #3339
Open
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infrmtcs
added
the
disable-deploy-test
infrmtcs
force-pushed
the
dat/bench/zstd1
branch
from
244c7a6 to
0ae1fd0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 76.36% 76.34% -0.03%
==========================================
Files 351 351
Lines 33309 33318 +9
==========================================
- Hits 25438 25437 -1
- Misses 6062 6069 +7
- Partials 1809 1812 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EgeCaner
reviewed
Dec 29, 2025
Contributor
EgeCaner
left a comment
EgeCaner
left a comment
There was a problem hiding this comment.
Looks good, dropped some questions
| } | ||
|
|
||
| var Zstd1 = func() block.CompressionProfile { | ||
| zstd1 := block.BalancedCompression.ValueBlocks |
Contributor
There was a problem hiding this comment.
Is this only to take compression.ZstdLevel1 from the predefined compressionProfile? If so can we directly use compression.ZstdLevel1? Is it missing the registry or something?
| name += "v2 -> " | ||
| } | ||
| name += "v2zstd" | ||
| name += "v2good" |
Contributor
There was a problem hiding this comment.
Where this name is coming from?
Contributor
Author
There was a problem hiding this comment.
My bad, this PR was created by modifying my "good compression" experiment branch.
infrmtcs
force-pushed
the
dat/bench/zstd1
branch
from
53e1fc4 to
80b661a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.