fix(rlp): pass ValueDecoderContext by ref in DecodeStorageRootOnly#10842
Merged
LukaszRozmej merged 3 commits intoMar 16, 2026
Merged
Conversation
LukaszRozmej
approved these changes
Mar 16, 2026
Member
LukaszRozmej
left a comment
LukaszRozmej
left a comment
There was a problem hiding this comment.
fortunately this is one-off throw away ValueDecoderContext, so it doesn't really affect anything in current usages. But should be by ref
stdevMac
pushed a commit
that referenced
this pull request
Mar 19, 2026
…10842) * fix(rlp): pass ValueDecoderContext by ref in DecodeStorageRootOnly * Update AccountDecoderTests.cs --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecodeStorageRootOnly called DecodeStorageRoot without ref, so position changes were lost (ValueDecoderContext is a ref struct). Bug introduced in #6722 during RlpStream to ValueDecoderContext migration. Removed the duplicate non-ref DecodeStorageRoot overload and added a regression test.