refactor: extract FullPruner init into overridable IFullPrunerFactory#11066
Merged
Conversation
FullPruner was instantiated as a side effect inside PruningTrieStateFactory.Build(), making it impossible to override via DI. Extract the initialization into IFullPrunerFactory with a default FullPrunerFactory implementation registered in WorldStateModule. This allows plugins to swap full pruning behavior by overriding the IFullPrunerFactory registration. Also promotes CompositePruningTrigger to a DI singleton. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Closed
16 tasks
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hudem1
approved these changes
Apr 8, 2026
LukaszRozmej
approved these changes
Apr 8, 2026
|
|
||
| public interface IFullPrunerFactory | ||
| { | ||
| void Initialize(IStateReader stateReader, IPruningTrieStore trieStore); |
Member
There was a problem hiding this comment.
It is bit weird that it doesn't retuen anything
Contributor
Author
There was a problem hiding this comment.
Its side effect thing, making it icky.
Contributor
Author
There was a problem hiding this comment.
Done. Changed to FullPruner? Create(...) — the caller now handles dispose registration. -- Claude
| } | ||
|
|
||
| IDriveInfo? drive = fileSystem.GetDriveInfos(pruningDbPath).FirstOrDefault(); | ||
| FullPruner pruner = new( |
Member
There was a problem hiding this comment.
maybe return FullPrunner here and add to Dispose stack in the caller?
Contributor
Author
There was a problem hiding this comment.
Done. Factory now returns FullPruner? and the caller in PruningTrieStateFactory.Build() pushes it to the dispose stack. Also removed IDisposableStack from the factory constructor. -- Claude
Make IFullPrunerFactory.Create return FullPruner? so the caller manages dispose registration, removing the hidden side-effect of the factory pushing to IDisposableStack internally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FullPrunerinitialization fromPruningTrieStateFactory.Build()side effect into a newIFullPrunerFactoryinterfaceFullPrunerFactoryimplementation preserves existing behaviorCompositePruningTriggerto a DI singletonIFullPrunerFactoryChanges
IFullPrunerFactoryinterface inNethermind.Blockchain/FullPruning/FullPrunerFactorydefault implementation inNethermind.Init/WorldStateModule— registersCompositePruningTriggerandIFullPrunerFactoryas singletonsPruningTrieStateFactory— delegates toIFullPrunerFactory.Initialize(), removes 4 unused constructor paramsFlatWorldStateModule— adds stubs for new registrationsTest plan
dotnet buildpassesFullPrun*tests pass🤖 Generated with Claude Code