eth_estimateGas fix error decoding#11077
Merged
Merged
Conversation
svlachakis
changed the title
16 tasks
LukaszRozmej
approved these changes
Apr 9, 2026
Member
LukaszRozmej
left a comment
LukaszRozmej
left a comment
There was a problem hiding this comment.
Is this cross-checked with other clients?
LukaszRozmej
reviewed
Apr 9, 2026
Contributor
Author
Geth separates message (human-readable, ABI-decoded) from data (raw hex). Nethermind currently puts everything in message and code -32000 instead of 3. That's a bigger existing difference, which we I think we should tackle separately - this just fixes not returning bytes in the response. |
alexb5dh
approved these changes
Apr 9, 2026
LukaszRozmej
reviewed
Apr 9, 2026
benaadams
reviewed
Apr 9, 2026
benaadams
approved these changes
Apr 9, 2026
stdevMac
pushed a commit
that referenced
this pull request
Apr 10, 2026
* EncodeErrorMessage fixes & tests * handle with IndexOfAnyInRange * span * SearchValues * cleaner approach
svlachakis
added a commit
that referenced
this pull request
Apr 10, 2026
* EncodeErrorMessage fixes & tests * handle with IndexOfAnyInRange * span * SearchValues * cleaner approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #11059
Changes
EncodeErrorMessage fixes & tests
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?