Skip to content

ci: chunk Legacy VM test on ubuntu-latest for coverage#11113

Merged
newmanifold merged 1 commit into
masterfrom
test/legacy-vm-split
Apr 13, 2026
Merged

ci: chunk Legacy VM test on ubuntu-latest for coverage#11113
newmanifold merged 1 commit into
masterfrom
test/legacy-vm-split

Conversation

@newmanifold
Copy link
Copy Markdown
Contributor

@newmanifold newmanifold commented Apr 12, 2026

Changes

  • Split Ethereum.Legacy.VM.Test into 8 chunks on ubuntu-latest where coverage instrumentation makes it too slow.
  • ARM runner keeps the unchunked single job (~3m without coverage)
  • Reverts the timeout bump from ci: bump tests-spec timeout to 20m #11109 back to 15m since chunking lowers the worst case time to ~8m

Problem

Ethereum.Legacy.VM.Test consistently timed out on ubuntu-latest with coverage enabled even with 20m timeout. With coverage: ~46m (run)

Solution

Chunk the test into 8 parts on ubuntu-latest only. With coverage, each chunk takes ~3-7m, well within the 15m timeout:

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

Notes on testing

Validated with push-triggered runs with forced coverage on the test branch.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@newmanifold newmanifold force-pushed the test/legacy-vm-split branch from a2f29b0 to ada8b92 Compare April 12, 2026 23:49
@newmanifold newmanifold marked this pull request as ready for review April 13, 2026 00:09
@newmanifold newmanifold requested a review from rubo as a code owner April 13, 2026 00:09
Copy link
Copy Markdown
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arn't we hitting some limit on how many workflows we are spamming?

@newmanifold newmanifold force-pushed the test/legacy-vm-split branch from ada8b92 to 49b9c0a Compare April 13, 2026 08:31
@newmanifold
Copy link
Copy Markdown
Contributor Author

newmanifold commented Apr 13, 2026

Arn't we hitting some limit on how many workflows we are spamming?

256 jobs per workflow, and we haven't added any new workflow.

Split Ethereum.Legacy.VM.Test into 8 chunks on ubuntu-latest where
coverage instrumentation makes it too slow (~46m) for the 15m timeout.
ARM runner keeps the unchunked single job (~1m without coverage).

Uses the chunk: [''] matrix trick with exclude/include to keep the
change contained to tests-spec without adding new jobs.
@newmanifold newmanifold force-pushed the test/legacy-vm-split branch from 49b9c0a to c35b82b Compare April 13, 2026 09:09
@newmanifold newmanifold merged commit 5579617 into master Apr 13, 2026
435 checks passed
@newmanifold newmanifold deleted the test/legacy-vm-split branch April 13, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants