Skip to content

fix build - BenchmarkDotNet Version#11253

Merged
AnkushinDaniil merged 1 commit into
masterfrom
fix/benchmarkdotnet-nightly-bump-472
Apr 20, 2026
Merged

fix build - BenchmarkDotNet Version#11253
AnkushinDaniil merged 1 commit into
masterfrom
fix/benchmarkdotnet-nightly-bump-472

Conversation

@AnkushinDaniil
Copy link
Copy Markdown
Contributor

@AnkushinDaniil AnkushinDaniil commented Apr 20, 2026

Summary

Bump BenchmarkDotNet and BenchmarkDotNet.Diagnostics.Windows from 0.16.0-nightly.20260320.468 to 0.16.0-nightly.20260322.472.

The pinned .468 build was unpublished from NuGet and is no longer restorable, which fails the Build matrix on master and every open PR with NU1603 (treated as error). NuGet auto-resolves to .472 as the nearest available nightly.

Recurrence of the same failure mode as #11152 (which bumped .466.468 five days ago).

CI error

error NU1603: Warning As Error: Nethermind.Precompiles.Benchmark.Test depends on
BenchmarkDotNet (>= 0.16.0-nightly.20260320.468) but BenchmarkDotNet
0.16.0-nightly.20260320.468 was not found. BenchmarkDotNet
0.16.0-nightly.20260322.472 was resolved instead.

@github-actions github-actions Bot added bug fix + reliability dependencies Pull requests that update a dependency file labels Apr 20, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 20, 2026

Claude finished @AnkushinDaniil's task in 51s —— View job


Review

  • Read changed file (Directory.Packages.props)
  • Loaded package management rules
  • Analyzed changes

Verdict: LGTM — no issues found.

The change is minimal and surgical:

  • Both BenchmarkDotNet and BenchmarkDotNet.Diagnostics.Windows are bumped together to the same version 0.16.0-nightly.20260322.472, maintaining the required version alignment between the two packages.
  • The update is correctly placed only in Directory.Packages.props per the repo's Central Package Management (CPM) rules — no .csproj files touched.
  • The root cause is well-described: .468 was unpublished from NuGet causing a hard NU1603 build failure; .472 is the next available nightly.

No critical, high, or medium issues.

Low / informational: The repo is now pinned to a nightly build for the third time in a short window (.466.468.472). As a long-term consideration, tracking whether BenchmarkDotNet has a stable 0.16.0 release or pinning to a known-stable nightly could reduce CI noise — but that's out of scope for this emergency fix.

Copy link
Copy Markdown
Contributor

@svlachakis svlachakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have fixed that 3 times last week, should we consider using stable release? @LukaszRozmej @benaadams @kamilchodola ?

@AnkushinDaniil AnkushinDaniil merged commit cd31b02 into master Apr 20, 2026
447 checks passed
@AnkushinDaniil AnkushinDaniil deleted the fix/benchmarkdotnet-nightly-bump-472 branch April 20, 2026 12:32
@benaadams
Copy link
Copy Markdown
Member

We have fixed that 3 times last week, should we consider using stable release? @LukaszRozmej @benaadams @kamilchodola ?

When the next make a stable release

asdacap pushed a commit that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix + reliability dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants