feat: add SkipMetricsTracking property to DbSettings

[cbermudez97]

Changes

• Introduced SkipMetricsTracking property in DbSettings to control metrics tracking for specific databases.
• Updated FullPruningInnerDbFactory to set SkipMetricsTracking to true for inner databases to prevent stale references after pruning.
• Added unit tests to verify the behavior of metrics tracking based on the new property.
• Enhanced DbMonitoringModule to respect the SkipMetricsTracking setting when adding databases to the tracker.

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[claude]

Claude finished @cbermudez97's task in 3m 42s —— View job

---

PR Review: feat: add SkipMetricsTracking property to DbSettings

• Gather context and read changed files
• Load relevant AGENTS rules
• Review all changed files
• Post inline comments
• Post final summary

---

Summary

The fix is correct and well-designed. The root cause is clear: FullPruningInnerDbFactory creates indexed sub-DBs that get registered into the DbTracker via the DbFactoryInterceptor. After a pruning cycle, the old inner DB is discarded but still held in the tracker — a stale reference. The solution is sound:

1. FullPruningInnerDbFactory sets SkipMetricsTracking = true on all inner DB settings so the interceptor never registers them.
2. WorldStateModule manually registers the outer FullPruningDb wrapper once with a stable name. Since FullPruningDb.GatherMetric() delegates to _currentDb.GatherMetric(), the tracker always reads from whatever inner DB is currently active — automatically correct across pruning cycles.
3. The DbFactoryInterceptor correctly gates on !dbSettings.SkipMetricsTracking for both CreateDb and CreateColumnsDb.

The propagation through DbSettings.Clone() is safe: MemberwiseClone copies the field, then GetRocksDbSettings explicitly overwrites it to true after cloning.

---

Findings

Severity	Count
Critical	0
High	0
Medium	0
Low	3

Low — SkipMetricsTracking lacks XML docs (DbSettings.cs:15)
The coding style guide requires <summary> on all public APIs. The semantics here are non-obvious (callers don't know what it affects), so a one-liner doc would help. Other properties in the same class are also undocumented, so this is consistent with the existing pattern.

Low — TryAdd silently drops duplicate registrations (WorldStateModule.cs:45)
Not a production issue (singletons aren't recreated), but worth being aware of in test teardown/rebuild scenarios.

Low — No end-to-end regression test for the stale-reference bug (DbTrackerTests.cs:81)
TestSkipMetricsTracking validates the mechanism, but there's no test that exercises the full scenario: create FullPruningDb → trigger pruning cycle via TryStartPruning/Commit → assert tracker still reads from the new inner DB. The unit test is sufficient to merge, but an integration test would give stronger confidence.

---

Verdict: ready to merge. All findings are low-severity and none block correctness.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a SkipMetricsTracking flag to DbSettings and updates DB monitoring to avoid tracking ephemeral inner DB instances created during full pruning, preventing stale references and improving resilience when metric gathering fails.

Changes:

• Add DbSettings.SkipMetricsTracking and honor it in DbMonitoringModule’s DB factory interceptor.
• Mark full-pruning inner DB instances as skipped, and register the stable FullPruningDb wrapper with the tracker.
• Add unit tests for skip-tracking behavior and for per-DB metric gather exception isolation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Nethermind/Nethermind.Init/Modules/WorldStateModule.cs	Registers the FullPruningDb wrapper in the tracker to keep metrics tied to the active inner DB across prune cycles.
src/Nethermind/Nethermind.Init/Modules/DbMonitoringModule.cs	Skips tracking based on SkipMetricsTracking and makes metric updates resilient to per-DB exceptions.
src/Nethermind/Nethermind.Db/FullPruning/FullPruningInnerDbFactory.cs	Sets SkipMetricsTracking = true for indexed inner DB instances.
src/Nethermind/Nethermind.Db/DbSettings.cs	Introduces the SkipMetricsTracking property.
src/Nethermind/Nethermind.Db.Test/Nethermind.Db.Test.csproj	Adds test dependency on Nethermind.Init to access DbMonitoringModule/tracker types.
src/Nethermind/Nethermind.Db.Test/DbTrackerTests.cs	Adds tests for skip-tracking and exception isolation during metrics update.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.