Don't crash parsing ABF files with an invalid acquisition date#1866
Conversation
zm711
left a comment
There was a problem hiding this comment.
Just one general question @h-mayorquin.
53de479 to
5c4e286
Compare
| uv.lock | ||
| .venv No newline at end of file | ||
| .venv | ||
| .python-version No newline at end of file |
There was a problem hiding this comment.
Interesting where did this come from?
There was a problem hiding this comment.
this is a uv thing.
|
At the end: For version 2 I replaced the For version 1 I did the equivalent, but on the time field rather than the date field. That path hardcodes the date to 1900 and only reads Both are covered by a test asserting that |
|
This should be ready. |
Some ABF files store a "no date" sentinel (all bits set) in their date header fields, and
AxonRawIOcurrently raises while building the recording datetime from those values, which blocks reading the file entirely even though the date is non-essential annotation. Both the ABF v1 and ABF v2 paths produce out-of-range values from this sentinel, so parsing now falls back to aNonerecording datetime rather than failing, keeping the signal accessible.