processGraph(): Don't throw ThreadPoolShutDown if there is an exception #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes $ nix copy --derivation --to /tmp/nix /nix/store/... error: cannot enqueue a work item while the thread pool is shutting down The ThreadPoolShutDown exception was hiding the reason for the thread pool shut down, e.g. error: cannot add path '/nix/store/03sl46khd8gmjpsad7223m32ma965vy9-fix-static.patch' because it lacks a signature by a trusted key
edolstra
force-pushed
the
fix-thread-pool-error
branch
from
bc70a99 to
a8c69cc
Compare
roberth
approved these changes
Jan 20, 2025
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
A valid solution for an instance of the problem.
We'll have more instances of this. Perhaps enqueue should always succeed, and it could return a promise from which the exception could be read.
Alternatively, we could migrate to a standard pool implementation, if possible.
This was referenced Jan 20, 2025
Merged
roberth
added
automatic backport
edolstra
added a commit
that referenced
this pull request
Jan 20, 2025
…2294 processGraph(): Don't throw ThreadPoolShutDown if there is an exception (backport #12294)
edolstra
added a commit
that referenced
this pull request
Jan 20, 2025
…2294 processGraph(): Don't throw ThreadPoolShutDown if there is an exception (backport #12294)
roberth
added
the
backports created
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-20-nix-team-meeting-minutes-209/59119/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes
The
ThreadPoolShutDownexception was hiding the reason for the thread pool shut down, e.g.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.