Exclude 'dir' from the FlakeRef's URL #12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where nix would try to check out invalid URLs, because it would pass 'dir' to the HTTP endpoint. For later versions this was fixed in b2be6fe. This is a backport of just the relevant part. See NixOS#12417
Mic92
reviewed
Apr 15, 2025
| return std::nullopt; | ||
| } | ||
|
|
||
| const auto subdir = getOr(parsedURL.query, "dir", ""); |
Author
There was a problem hiding this comment.
If you're asking about the code: there should be nothing missing (unless I am missing something). I left it as a draft since it seemed in some comments that there's no interest in a backport.
Member
|
I believe this is fixed by #13159 no? |
Member
|
@Mic92 That fixed it on master, this is a backport to 2.24. |
Author
|
Sorry for the delay, I thought it might not be of interest after #13159 but it indeed solves the problem for 2.24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes an issue where nix would try to check out invalid URLs, because it would pass 'dir' to the HTTP endpoint.
For later versions this was fixed in b2be6fe. This is a backport of just the relevant part.
Context
See #12417, where this is first discussed.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.