Fix jobset evaluation #12888
Merged
Fix jobset evaluation #12888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
added
the
backport 2.28-maintenance
Some of the maintainer attribute names got changed in nixos-unstable (e.g. "edolstra" is now "eelco") but we want this flake to work on nixos-24.11. So just get rid of them.
edolstra
force-pushed
the
fix-maintainers
branch
from
b87b16f to
93d8f62
Compare
edolstra
added a commit
that referenced
this pull request
Apr 3, 2025
…2888 Fix jobset evaluation (backport #12888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The jobset is currently broken, see https://hydra.nixos.org/jobset/nix/maintenance-2.28:
Some of the maintainer attribute names got changed in nixos-unstable (e.g. "edolstra" is now "eelco") but we want this flake to work on nixos-24.11 so we can't just rename them. So let's just get rid of them.
Ideally our GitHub CI would have caught this, but I guess
nix flake checkdoesn't look atmeta.maintainers.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.