Fix some unlinked tests #12958
Merged
Fix some unlinked tests #12958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Apr 7, 2025
Member
There was a problem hiding this comment.
👀 Is there some way we can extend our meson files to fail (or at least warn) if there is a file that exists that isn't in this list? And then an explicit "yeah that's fine" allowlist of files that we don't need in this list (and related lists, I guess)
Member
Author
There was a problem hiding this comment.
Would be great but it's beyond my Meson knowledge. Maybe @Ericson2314 knows?
Member
There was a problem hiding this comment.
No, but we could shell out for a glob: https://mesonbuild.com/FAQ.html#but-i-really-want-to-use-wildcards
Member
There was a problem hiding this comment.
I think dynamic derivations will offer us an opportunity to improve this once and for all
Ericson2314
added
the
backport 2.28-maintenance
edolstra
added a commit
that referenced
this pull request
Apr 8, 2025
…2958 Fix some unlinked tests (backport #12958)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
monitorfdhuptest.Found by @grahamc running clang-tidy.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.