Skip to content

Conversation

@xokdvium
Copy link
Contributor

…or tests

Motivation

This was failing under ASAN in https://hydra.nixos.org/build/315173638/nixlog/1. ASAN uses a bit more stack space and the default max call depth is not enough. Not sure what's so special about this particular test.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

…or tests

This was failing under ASAN in https://hydra.nixos.org/build/315173638/nixlog/1.
ASAN uses a bit more stack space and the default max call depth is not enough.
Not sure what's so special about this particular test.
@xokdvium xokdvium requested a review from roberth November 28, 2025 22:17
@xokdvium xokdvium requested a review from edolstra as a code owner November 28, 2025 22:17
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Nov 28, 2025
@roberth
Copy link
Member

roberth commented Nov 29, 2025

No idea either, but this lgtm

@xokdvium xokdvium added this pull request to the merge queue Nov 29, 2025
Merged via the queue into master with commit 0903b0a Nov 29, 2025
20 checks passed
@xokdvium xokdvium deleted the fix-asan-stack-overload-repl-doc branch November 29, 2025 01:21
@edolstra edolstra mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants