linux-derivation-builder: Explicitly specify nstype for setns calls i…#15056
Merged
Ericson2314 merged 1 commit intomasterfrom Jan 23, 2026
Merged
linux-derivation-builder: Explicitly specify nstype for setns calls i…#15056Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
…n addDependencyImpl We already use file descriptors for this, so 0 is perfectly fine here, but this still serves as a sanity check and slightly more self-documenting.
Ericson2314
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n addDependencyImpl
Motivation
We already use file descriptors for this, so
0is perfectly fine here, but this still serves as a sanity check and slightly more self-documenting.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.