Skip to content

libstore: check ca-derivations xp in Store::queryRealisation#15528

Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom
obsidiansystems:query-realisation-xp-check
Mar 19, 2026
Merged

libstore: check ca-derivations xp in Store::queryRealisation#15528
Ericson2314 merged 2 commits intoNixOS:masterfrom
obsidiansystems:query-realisation-xp-check

Conversation

@amaanq
Copy link
Member

@amaanq amaanq commented Mar 19, 2026

Motivation

This is a more comprehensive fix than the one done in that this replaces
ee5860f, because it affects all store types.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added store Issues and pull requests concerning the Nix store c api Nix as a C library with a stable interface labels Mar 19, 2026
amaanq added 2 commits March 19, 2026 16:28
Mutating global state in tests is fragile since manual restore calls are
easy to forget or skip on early returns; an RAII guard ensures cleanup
always happens.
This is a more comprehensive fix than the one done in that this replaces
ee5860f, because it affects all store types.
@amaanq amaanq force-pushed the query-realisation-xp-check branch from 5d59b01 to d054314 Compare March 19, 2026 20:29
@Ericson2314 Ericson2314 enabled auto-merge March 19, 2026 20:30
@Ericson2314 Ericson2314 added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Mar 19, 2026
@Ericson2314 Ericson2314 added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Mar 19, 2026
@Ericson2314 Ericson2314 added this pull request to the merge queue Mar 19, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Mar 19, 2026
@Ericson2314 Ericson2314 added this pull request to the merge queue Mar 19, 2026
Merged via the queue into NixOS:master with commit 58b6804 Mar 19, 2026
16 checks passed
@Ericson2314 Ericson2314 deleted the query-realisation-xp-check branch March 19, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c api Nix as a C library with a stable interface store Issues and pull requests concerning the Nix store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants