Expanding tests and docs relating to deleting profiles#8351
Expanding tests and docs relating to deleting profiles#8351Ericson2314 merged 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
with-tests
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
This is clearly an improvement and should prevent lots of confusion over how things work.
|
Thanks for the thorough review! No comments on the test part though! Should we land that first? (I made it the first commit for a reason :D.) |
Ericson2314
force-pushed
the
delete-profiles-tests-docs
branch
4 times, most recently
from
2f0dd64 to
a31b3f9
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-05-18-learning-journey-working-group-meeting-notes-9/28405/3 |
| *Example*: `30d` | ||
|
|
||
| Delete all generations older than *days* days. | ||
| The generation that was active at that point in time is excluded, and will not be deleted. |
There was a problem hiding this comment.
I really don't know what this is supposed to mean.
There was a problem hiding this comment.
This is taking the parenthetical from above and making it a standalone sentence --- I am not sure exactly either!
We can figure it out and make it clear in a follow-up PR. For now, it is at least no worse than before.
There was a problem hiding this comment.
This command will delete all generations older than 30 days, except for the generation that was active 30 days ago (if it currently exists).
This is my interpretation, from the examples.
There was a problem hiding this comment.
Maybe to slightly clarify then...
| The generation that was active at that point in time is excluded, and will not be deleted. | |
| The generation that was active at that point in the past is excluded, and will not be deleted. |
There was a problem hiding this comment.
Yeah I like it. I will go read the code now to double check too.
Good for test parallelism, and separation of concerns (core GC vs profiles deleting).
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Ericson2314
force-pushed
the
delete-profiles-tests-docs
branch
from
ba323ed to
5b7e285
Compare
4 participants
Motivation
Improve docs and tests of commands relating to deleting profiles.
Context
#8154 got me thinking about this stuff.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.