Skip to content

coturn: Support secrets file for configuring the static-auth-secret#129059

Merged
Mic92 merged 3 commits intoNixOS:masterfrom
MatthewCroughan:coturn-secrets-file-rebase
Jul 3, 2021
Merged

coturn: Support secrets file for configuring the static-auth-secret#129059
Mic92 merged 3 commits intoNixOS:masterfrom
MatthewCroughan:coturn-secrets-file-rebase

Conversation

@MatthewCroughan
Copy link
Copy Markdown
Contributor

@MatthewCroughan MatthewCroughan commented Jul 3, 2021

Motivation for this change

This PR simply rebases #75263 on master.

This change allows for the coturn shared secret to be stored in a file outside the nix store.
It also makes it easier to publish configurations in public VCS with fewer issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 3, 2021
@MatthewCroughan MatthewCroughan force-pushed the coturn-secrets-file-rebase branch 2 times, most recently from a90ddc1 to 8885d32 Compare July 3, 2021 02:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 3, 2021
@MatthewCroughan
Copy link
Copy Markdown
Contributor Author

I have tested this as working on 21.05 on a Hetzner server I own.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Jul 3, 2021

@GrahamcOfBorg test coturn

@MatthewCroughan MatthewCroughan force-pushed the coturn-secrets-file-rebase branch 2 times, most recently from 37db4b3 to ce31cd2 Compare July 3, 2021 07:22
kampka and others added 3 commits July 3, 2021 08:29
Co-authored-by: MatthewCroughan <matt@croughan.sh>
Adds passthru.tests.coturn = nixosTests.coturn;
@MatthewCroughan MatthewCroughan force-pushed the coturn-secrets-file-rebase branch from ce31cd2 to 5df1e9d Compare July 3, 2021 07:33
@MatthewCroughan
Copy link
Copy Markdown
Contributor Author

I've adjusted the authorship and split the commits out appropriately.

@Mic92 Mic92 merged commit 296627f into NixOS:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants