Skip to content

python3Packages.asyncua: init at 1.0.0#196552

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
harvidsen:python-asyncua-init
Nov 28, 2022
Merged

python3Packages.asyncua: init at 1.0.0#196552
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
harvidsen:python-asyncua-init

Conversation

@harvidsen
Copy link
Copy Markdown
Contributor

@harvidsen harvidsen commented Oct 18, 2022 •
edited
Loading

Description of changes

Add python package asyncua.

The package also provides a cli tool, but I propose only adding it as a package for now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 18, 2022
@harvidsen harvidsen force-pushed the python-asyncua-init branch from 510d545 to 26b53ae Compare October 18, 2022 07:47
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 18, 2022
@harvidsen harvidsen force-pushed the python-asyncua-init branch from 26b53ae to 8488310 Compare October 18, 2022 07:52
@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Oct 18, 2022

Result of nixpkgs-review pr 196552 run on x86_64-linux 1

2 packages built:
  • python310Packages.asyncua
  • python39Packages.asyncua

fabaff
fabaff reviewed Oct 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pythonImportsCheck as an additional safe-guard.

pkgs/development/python-modules/asyncua/default.nix Outdated
Comment on lines 37 to 47
Copy link
Copy Markdown
Member

@fabaff fabaff Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/FreeOpcUa/opcua-asyncio/blob/master/setup.py#L26

Suggested change
typing-extensions
];
] ++ lib.optionals (pythonOlder "3.8") [
typing-extensions
];

Copy link
Copy Markdown
Contributor Author

@harvidsen harvidsen Oct 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added importlib-metadata as conditional dependency for pythonOlder "3.8", as it says in setup.py. Is there a similarity between importlib-metadata and typing-extensions i should be aware of? However, build fails with

> ERROR: Could not find a version that satisfies the requirement typing-extensions>=3.7.2 (from aiosqlite) (from versions: none)
> ERROR: No matching distribution found for typing-extensions>=3.7.2

on all python versions when typing-extensions is not explicitly added. I don't understand why this is not included with aiosqlite.

@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Oct 20, 2022 •
edited
Loading

Thanks for reviewing @fabaff! I left all commits intact for easier re-review, but will of course squash when it is ready.

@harvidsen harvidsen requested a review from fabaff October 20, 2022 13:10
@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Oct 20, 2022

Result of nixpkgs-review pr 196552 run on x86_64-linux 1

2 packages built:
  • python310Packages.asyncua
  • python39Packages.asyncua

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Oct 28, 2022

Could you please squash the commit?

@harvidsen harvidsen force-pushed the python-asyncua-init branch from 8ff229e to 7cb9193 Compare October 31, 2022 08:52
@harvidsen harvidsen changed the title python3Packages.asyncua: init at 0.9.98 python3Packages.asyncua: init at 1.0.0 Oct 31, 2022
@harvidsen harvidsen force-pushed the python-asyncua-init branch from 7cb9193 to c6f0740 Compare October 31, 2022 11:17
@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Oct 31, 2022

Result of nixpkgs-review pr 196552 run on x86_64-linux 1

2 packages built:
  • python310Packages.asyncua
  • python39Packages.asyncua

1 similar comment
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Nov 2, 2022

Result of nixpkgs-review pr 196552 run on x86_64-linux 1

2 packages built:
  • python310Packages.asyncua
  • python39Packages.asyncua

@harvidsen harvidsen force-pushed the python-asyncua-init branch 2 times, most recently from c9980d0 to be75e21 Compare November 15, 2022 08:50
@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Nov 15, 2022

Result of nixpkgs-review pr 196552 run on x86_64-linux 1

2 packages built:
  • python310Packages.asyncua
  • python39Packages.asyncua

@harvidsen
Copy link
Copy Markdown
Contributor Author

harvidsen commented Nov 15, 2022

Thanks for the help @fabaff. I have squashed in your c9980d0aee4c74724db6e56e6a78f0a4c687ec1a. I think this is ready to merge now?

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Nov 28, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1480

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Nov 28, 2022

@ofborg build python3Packages.asyncua

@SuperSandro2000 SuperSandro2000 merged commit dfc8fe3 into NixOS:master Nov 28, 2022
@harvidsen harvidsen deleted the python-asyncua-init branch March 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harvidsen @fabaff @nixos-discourse @SuperSandro2000