Skip to content

coder: init at 0.12.4#200070

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
urandom2:coder
Nov 8, 2022
Merged

coder: init at 0.12.4#200070
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
urandom2:coder

Conversation

@urandom2
Copy link
Contributor

@urandom2 urandom2 commented Nov 7, 2022

Description of changes

Fixes #198207

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1376

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 7, 2022
@SuperSandro2000 SuperSandro2000 merged commit e67f6e8 into NixOS:master Nov 8, 2022
@dit7ya
Copy link
Member

dit7ya commented Nov 12, 2022

I think this package does not work as expected as it does not include the web UI (Try running coder server and visiting the url provided).

There is a much more detailed PR open currently, which also includes a nixos module - #197613

@urandom2
Copy link
Contributor Author

I did describe this change as "I have not tested the output binary", but it does compile. I was hoping that we might get some feedback from real users, as I was packaging it.

Should we merge another change to mark this as broken?

@urandom2 urandom2 deleted the coder branch December 1, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[package request] coder - remote development environments on your infrastructure provisioned with Terraform

4 participants