Skip to content

Comments

nodePackages.rush: init at 5.88.0#207353

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Lord-Valen:init/nodePackages.rush
Jan 6, 2023
Merged

nodePackages.rush: init at 5.88.0#207353
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Lord-Valen:init/nodePackages.rush

Conversation

@Lord-Valen
Copy link
Contributor

@Lord-Valen Lord-Valen commented Dec 23, 2022

Description of changes

Added rush, a node monorepo management utility.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Luflosi, teutat3s and winterqt December 23, 2022 01:38
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Dec 23, 2022
@nixos-discourse
Copy link

nixos-discourse commented Jan 5, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1660

@SuperSandro2000 SuperSandro2000 merged commit 0cf9da5 into NixOS:master Jan 6, 2023
@thefloweringash thefloweringash mentioned this pull request Jan 11, 2023
Closed
@Lord-Valen Lord-Valen deleted the init/nodePackages.rush branch March 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s Awaiting requested review from teutat3s

@Luflosi Luflosi Awaiting requested review from Luflosi

@winterqt winterqt Awaiting requested review from winterqt

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lord-Valen @nixos-discourse @SuperSandro2000