Skip to content

rubyPackages.fast_excel: add initial support#209186

Open
jonknapp wants to merge 1 commit intoNixOS:masterfrom
jonknapp:patch-2
Open

rubyPackages.fast_excel: add initial support#209186
jonknapp wants to merge 1 commit intoNixOS:masterfrom
jonknapp:patch-2

Conversation

@jonknapp
Copy link
Copy Markdown
Contributor

@jonknapp jonknapp commented Jan 5, 2023

Description of changes

Added support for fast_excel gem which requires zlib.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Locally, I am using the following to add it to defaultGemConfig for now (tested only on Linux).

      pkgs = nixpkgs.legacyPackages.${system};
      gems = pkgs.bundlerEnv.override
          {
            inherit bundler;
          }
          {
            inherit ruby;
            name = "my-app";
            gemdir = ./.;
            gemConfig = pkgs.defaultGemConfig // {
              fast_excel = attrs: {
                buildInputs = [ pkgs.zlib ];
              };
            };
          };

@jonknapp jonknapp requested a review from marsam as a code owner January 5, 2023 16:47
@github-actions github-actions bot added the 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. label Jan 5, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 5, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 5, 2024
Copy link
Copy Markdown
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and make sure the commit message follows CONTRIBUTING.md. LGTM otherwise

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants