Skip to content

ourpaint: init at 0.1#209448

Draft
fgaz wants to merge 3 commits intoNixOS:masterfrom
fgaz:ourpaint/init
Draft

ourpaint: init at 0.1#209448
fgaz wants to merge 3 commits intoNixOS:masterfrom
fgaz:ourpaint/init

Conversation

@fgaz
Copy link
Copy Markdown
Member

@fgaz fgaz commented Jan 7, 2023

Description of changes

#208940

There are still a couple of TODOs and I can't test it right now because I'm on a computer with old opengl, hence draft.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fgaz fgaz marked this pull request as draft January 7, 2023 10:27
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2023
@ChengduLittleA
Copy link
Copy Markdown

Keep in mind if you want to port this to other architectures, LaGUI (which is the basis of OurPaint) is designed for little-endian and 64bit systems. Big-endian systems will not work, 32 bit systems might work but not verified, and files saved with 32bit LaGUI (even if it works) are probably not readable in 64 bit systems. It's a rather simple backend without much care in cross-architecture portability.

@fgaz
Copy link
Copy Markdown
Member Author

fgaz commented Jan 8, 2023

Thanks, I'll update meta.platforms. Is it also supposed to be linux only?

@fgaz fgaz force-pushed the ourpaint/init branch 2 times, most recently from d9ad1fd to 1faf366 Compare January 8, 2023 18:48
@ChengduLittleA
Copy link
Copy Markdown

@fgaz I developed the backend on windows but now I don't have a windows machine, so I didn't port most of the functionalities back. If I were to do so it should run on windows as well. So for now just linux.

@fgaz fgaz added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jan 26, 2023
@Aleksanaa
Copy link
Copy Markdown
Member

What's the status of this?

@fgaz
Copy link
Copy Markdown
Member Author

fgaz commented Feb 7, 2024

Looks like it fell off my radar...

I'll try to update to the recently released 0.2a, thanks for the ping.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants