Open
Conversation
ofborg
bot
added
8.has: package (new)
AndersonTorres
suggested changes
May 4, 2023
Member
|
Now convert all this bunch of fixups in a single commit, with title |
Contributor
Author
|
Ack, done |
AndersonTorres
suggested changes
May 10, 2023
AndersonTorres
suggested changes
May 10, 2023
Member
There was a problem hiding this comment.
Suggested change
| make check | |
| make check |
AndersonTorres
suggested changes
May 20, 2023
Member
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
besides looks ok enough
|
|
||
| subdl = callPackage ../applications/video/subdl { }; | ||
|
|
||
| gaupol = callPackage ../applications/video/gaupol { }; |
Member
There was a problem hiding this comment.
Suggested change
| gaupol = callPackage ../applications/video/gaupol { }; | |
| gaupol = callPackage ../applications/video/gaupol { | |
| python = python39; | |
| }; |
| @@ -0,0 +1,73 @@ | |||
| { lib | |||
| , python39 | |||
Member
There was a problem hiding this comment.
Suggested change
| , python39 | |
| , python |
Comment on lines
+13
to
+15
| let | ||
| python = python39; | ||
| in python.pkgs.buildPythonApplication rec { |
Member
There was a problem hiding this comment.
Suggested change
| let | |
| python = python39; | |
| in python.pkgs.buildPythonApplication rec { | |
| python.pkgs.buildPythonApplication rec { |
| nativeCheckInputs = with python.pkgs; [ | ||
| flake8 | ||
| ]; | ||
|
|
| checkPhase = '' | ||
| make check | ||
| ''; | ||
|
|
| --replace '/gaupol-1.11.data/data/share' $out/share | ||
| done | ||
| ''; | ||
|
|
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding the Gaupol application, an editor for text-based subtitles.
https://otsaloma.io/gaupol/
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)I tested on my personal laptop running NixOS