makeBinaryWrapper: build static wrappers on static platforms

[risicle]

Description of changes

I'm not very big on static stdenv's so this may be naive, but it feels like we should be building static binary wrappers on static platforms.

Also fixed tests.makeBinaryWrapper to work on static platforms (though with sanitizers disabled)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

@NixOS/static

[Gerg-L]

This supersedes #320138

[alyssais]

This supersedes #320138

Comment on wrong PR?

[Gerg-L]

Sorry, #390021 is the other pr with the same intent.

[wolfgangwalther]

My comment from #390021 (comment) still applies, I believe. We should not try to replicate the same as the static adapter, but just use the NIX_CFLAGS... variables that are already set.

[wolfgangwalther]

We should not try to replicate the same as the static adapter, but just use the NIX_CFLAGS... variables that are already set.

These NIX_CFLAGS_... are unset on purpose for makeBinaryWrapper ever since #164163.

I see roughly the following options:

• Do something similar to this PR, i.e. recreate the same logic as in the static adapater in makeBinaryWrapper. We'd need to handle darwin, too. Possibly other adapters need the same, now or in the future.
• Remove the local NIX_CFLAGS_... override and try to filter its contents somehow, to only get supported flags. Don't even know how.
• Remove the local NIX_CFLAGS_... override and try to always run makeBinaryWrapper with the CC provided by the derivation - and then only fallback to the cc that is currently used when its not otherwise available.