bindfs: fix darwin build by disabling system binding#330366
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jul 30, 2024
Merged
bindfs: fix darwin build by disabling system binding#330366SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
Result of 1 package built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
NickCao
reviewed
Jul 27, 2024
ofborg
bot
added
the
10.rebuild-linux: 1
denbeigh2000
force-pushed
the
denbeigh/bindfs-macos
branch
from
a5027f6 to
35ce1b0
Compare
github-actions
bot
added
the
6.topic: python
This adds `--disable-macos-fs-link` to configureFlags on darwin platforms, removing /etc/fstab and `mount -t bindfs` support. This isn't ideal, but is better than the tool not building at all.
SuperSandro2000
approved these changes
Jul 30, 2024
denbeigh2000
force-pushed
the
denbeigh/bindfs-macos
branch
from
35ce1b0 to
3d54e5a
Compare
github-actions
bot
removed
the
6.topic: python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds
--disable-macos-fs-linkto configureFlags on darwin platforms, removing/etc/fstabandmount -t bindfssupport on the platform.This solution isn't ideal, but is better than the tool not building at all.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.