treewide: add missing installPhase hooks#333527
Draft
Sigmanificient wants to merge 1 commit intoNixOS:stagingfrom
Draft
treewide: add missing installPhase hooks#333527Sigmanificient wants to merge 1 commit intoNixOS:stagingfrom
Sigmanificient wants to merge 1 commit intoNixOS:stagingfrom
Conversation
491d549 to
6c5fa78
Compare
Contributor
|
Do you plan to work on this? Nice cleanup |
Member
Author
|
@qweered this can be regenerated at any time |
7aea2c4 to
3f6d88a
Compare
Sigmanificient
commented
Jan 22, 2026
Member
Author
Sigmanificient
left a comment
There was a problem hiding this comment.
Found an issue with cudatext while reviewing the diff
This was done using the following command:
grep -rP "installPhase ="
| cut -d ':' -f 1 \
| xargs -i sh -c "grep -P 'runHook\s+preInstall' {} >/dev/null ||
echo '{}'" | python add_missing_hooks.py
applying the following script:
https://gist.github.com/Sigmanificient/c68e03d1ad750a83233c6ab05761cbf2
3f6d88a to
c1d467b
Compare
Member
Author
|
removed the 2 problematic hit manually:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was done throw the following command:
with the following script:
https://gist.github.com/Sigmanificient/c68e03d1ad750a83233c6ab05761cbf2
2432hits,68miss are to be dealt with manuallyApplying the following:
for matching:
and (@emilazy suggestion):
matching:
Extra edits
Some minor adjustment were done to pass green on the CI:
pkgs/build-support/dotnet/dotnetenv/build-solution.nixstdenv/linux,glibcto avoid rebuildingstdenvThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.