Skip to content

Comments

build logseq from source (wip)#340128

Closed
aktaboot wants to merge 1 commit intoNixOS:masterfrom
aktaboot:logseq-source
Closed

build logseq from source (wip)#340128
aktaboot wants to merge 1 commit intoNixOS:masterfrom
aktaboot:logseq-source

Conversation

@aktaboot
Copy link
Contributor

@aktaboot aktaboot commented Sep 6, 2024

Description of changes

Attempt at building logseq from source,

  • for some reason it's not pulling in packages/amplify/dist/amplify.js during the build, so I added it through a patchfile
  • current issue encoutnered is that clojure's build is trying to fetch https://github.com/logseq/cljs-time/ during the build, which fails. The idea is to make clojure use a prefetched source

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 6, 2024
@donovanglover donovanglover added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Sep 6, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@aktaboot aktaboot closed this Apr 27, 2025
@aktaboot
Copy link
Contributor Author

#389363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants