Skip to content

Comments

benzene: init at 0-unstable-2022-12-18#341090

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
eilvelia:benzene
Dec 4, 2024
Merged

benzene: init at 0-unstable-2022-12-18#341090
wolfgangwalther merged 2 commits intoNixOS:masterfrom
eilvelia:benzene

Conversation

@eilvelia
Copy link
Member

@eilvelia eilvelia commented Sep 10, 2024

Description of changes

Adds benzene (also known as mohex and wolve), software for solving the Hex game.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 10, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Sep 10, 2024
@eilvelia
Copy link
Member Author

eilvelia commented Sep 10, 2024

(By the way, the "first-time contribution" label is wrong, I think. Perhaps that could be caused by username change.)

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 10, 2024
@Bot-wxt1221 Bot-wxt1221 self-requested a review September 24, 2024 09:03
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 25, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2000

@FliegendeWurst FliegendeWurst removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 6, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Nov 6, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 6, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 341090


x86_64-darwin

✅ 1 package built:
  • benzene

aarch64-darwin

✅ 1 package built:
  • benzene

@wolfgangwalther wolfgangwalther merged commit cdb5245 into NixOS:master Dec 4, 2024
@eilvelia eilvelia deleted the benzene branch December 4, 2024 21:58
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 19, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants