Skip to content

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 24, 2024

Description of changes

https://raw.githubusercontent.com/anmonteiro/piaf/refs/tags/0.2.0/CHANGES.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vbgl vbgl added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Sep 24, 2024
@vbgl vbgl requested a review from ulrikstrid as a code owner September 24, 2024 18:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 24, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 26, 2024
@vbgl vbgl merged commit d31bb1e into NixOS:master Sep 30, 2024
@vbgl vbgl deleted the ocaml-piaf-0.2.0 branch September 30, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants