Skip to content

nixos/dhcpcd: update sandboxing options #349041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rnhmjoj merged 1 commit into from
Jan 7, 2025
Merged

nixos/dhcpcd: update sandboxing options #349041

rnhmjoj merged 1 commit into from
Jan 7, 2025

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 16, 2024

Update sandboxing options.
Result:

systemd-analyze security dhcpcd
...
→ Overall exposure level for dhcpcd.service: 1.8 OK 🙂

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 16, 2024
@Izorkin Izorkin requested a review from rnhmjoj October 16, 2024 13:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 16, 2024
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Oct 16, 2024

@GrahamcOfBorg build dhcpcd.tests

rnhmjoj
rnhmjoj reviewed Oct 16, 2024
View reviewed changes
@Izorkin Izorkin force-pushed the update-dhcpcd-hardening branch from 0c53494 to a21281f Compare October 16, 2024 18:41
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
ck3d
ck3d reviewed Jan 5, 2025
View reviewed changes
@Izorkin Izorkin force-pushed the update-dhcpcd-hardening branch from a21281f to 21bb7ea Compare January 6, 2025 19:25
@Izorkin
Copy link
Contributor Author

Izorkin commented Jan 6, 2025

Rebased PR.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 6, 2025
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 6, 2025

@GrahamcOfBorg build dhcpcd.tests

@rnhmjoj rnhmjoj merged commit e7bd1e2 into NixOS:master Jan 7, 2025
23 of 31 checks passed
@Izorkin Izorkin deleted the update-dhcpcd-hardening branch January 8, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj left review comments

@ck3d ck3d ck3d left review comments

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Izorkin @rnhmjoj @ck3d @wegank