Skip to content

Conversation

@toonn
Copy link
Contributor

@toonn toonn commented Oct 16, 2024

Things done

Bumped the version and checked the glyphs rendered in Font Manager.

The links to the license appendices for NixOS and Nix on Darwin currently lead to error pages, I'm talking to JoyPixels to see if we can resolve this.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@toonn toonn changed the title Font joypixels emoji joypixels: 8.0.0 -> 9.0.0 Oct 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 16, 2024
@toonn toonn force-pushed the font-joypixels-emoji branch from 23678b5 to 2610a20 Compare October 31, 2024 12:08
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2024
@FliegendeWurst FliegendeWurst merged commit 00c682e into NixOS:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants