Skip to content

Comments

playonlinux: add python dependency pyasyncore#349576

Merged
donovanglover merged 1 commit intoNixOS:masterfrom
L-Trump:pkg-fix-playonlinux
Dec 31, 2024
Merged

playonlinux: add python dependency pyasyncore#349576
donovanglover merged 1 commit intoNixOS:masterfrom
L-Trump:pkg-fix-playonlinux

Conversation

@L-Trump
Copy link
Contributor

@L-Trump L-Trump commented Oct 18, 2024

Current playonlinux start failed with:

Looking for python3... 3.12.6 - selected
/nix/store/6hadbrvivhi7p31rz6rjx8dbl5m9r2ch-playonlinux-4.4/share/playonlinux/python/mainwindow.py:708: SyntaxWarning: invalid escape sequence '\|'
  self.SupprotedIconExt = "All|*.xpm;*.XPM;*.png;*.PNG;*.ico;*.ICO;*.jpg;*.JPG;*.jpeg;*.JPEG;*.bmp;*.BMP\
1.0
Traceback (most recent call last):
  File "/nix/store/6hadbrvivhi7p31rz6rjx8dbl5m9r2ch-playonlinux-4.4/share/playonlinux/python/mainwindow.py", line 41, in <module>
    import options, threading, debug
  File "/nix/store/6hadbrvivhi7p31rz6rjx8dbl5m9r2ch-playonlinux-4.4/share/playonlinux/python/options.py", line 21, in <module>
    from asyncore import dispatcher
ModuleNotFoundError: No module named 'asyncore'

Add corresponding dependency could fix the issue.

@pasqui23

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@L-Trump L-Trump requested a review from pasqui23 October 18, 2024 16:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2024
@pasqui23
Copy link
Contributor

LGTM

@L-Trump L-Trump added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 5, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 5, 2024
@donovanglover donovanglover merged commit 0212fb8 into NixOS:master Dec 31, 2024
@L-Trump L-Trump deleted the pkg-fix-playonlinux branch January 1, 2025 04:52
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 17, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants