bitwig-studio: fix MIDI input #361845
Merged
bitwig-studio: fix MIDI input #361845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding the entire /dev directory inside the Bubblewrap environment appears to fix MIDI, which broke after the Bubblewrap change in PR NixOS#360198.
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
Thanks for fixing this. For some reason, I put an outdated version of that file in my PR, very sorry for that. Actually, it should just work if you replace |
Contributor
Author
|
I have no clue either - I just tried things until it worked! Happy to change it if you think it makes more sense. |
ofborg
bot
added
10.rebuild-darwin: 1-10
bfortz
approved these changes
Dec 7, 2024
Philipp-M
approved these changes
Dec 7, 2024
wegank
added
the
12.approvals: 2
Contributor
|
Pinging @drupol : could you merge this please, it fixes an important issue. |
Contributor
|
sure, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding the entire /dev directory inside the Bubblewrap environment appears to fix MIDI, which broke after the Bubblewrap change in PR #360198.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.