Skip to content

Conversation

@Marlinc
Copy link
Contributor

@Marlinc Marlinc commented Dec 4, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 4, 2024
@Gerg-L
Copy link
Contributor

Gerg-L commented Dec 5, 2024

PR title and commit message should be "tmuxinator: 3.3.2 -> 3.3.3"

@Marlinc Marlinc changed the title tmuxinator: upgrade to version 3.3.3 tmuxinator: tmuxinator: 3.3.2 -> 3.3.3 Dec 5, 2024
@Marlinc
Copy link
Contributor Author

Marlinc commented Dec 5, 2024

I have updated the both now

@midischwarz12
Copy link
Member

No, tmuxinator: 3.3.2 -> 3.3.3 not tmuxinator: tmuxinator: 3.3.2 -> 3.3.3.

Copy link
Member

@midischwarz12 midischwarz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change commit message to exactly tmuxinator: 3.3.2 -> 3.3.3.

@Marlinc Marlinc changed the title tmuxinator: tmuxinator: 3.3.2 -> 3.3.3 tmuxinator: 3.3.2 -> 3.3.3 Dec 5, 2024
@Marlinc Marlinc requested a review from midischwarz12 December 5, 2024 15:02
@Marlinc
Copy link
Contributor Author

Marlinc commented Dec 5, 2024

Looks like I made copy paste mistake in the PR title, the commit was already tmuxinator: 3.3.2 -> 3.3.3

@midischwarz12
Copy link
Member

Commit is still tmuxinator: upgrade to version 3.3.3

@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 5, 2024
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 6, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 6, 2024
@Marlinc
Copy link
Contributor Author

Marlinc commented Dec 8, 2024

Thank you @midirhee12

@Marlinc
Copy link
Contributor Author

Marlinc commented Dec 15, 2024

@ericsagnes could you maybe have a look when you have time

@donovanglover donovanglover merged commit 083902d into NixOS:master Dec 25, 2024
39 checks passed
@Marlinc Marlinc deleted the tmuxinator-3.3.3 branch December 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants