heroic: patch Desktop Entry StartupWMClass
#365460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heroic usually has a WM Class of "Heroic", however for some reason the nixpkgs version has a WM Class of "heroic". This subtle discrepancy results in the app's window not being associated with its desktop entry, so it cannot be pinned, does not have an icon, etc.
github-actions
bot
added
10.rebuild-darwin: 0
4 tasks
aidalgol
approved these changes
Dec 16, 2024
MattSturgeon
added
12.approvals: 1
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroic usually has a WM Class of "Heroic", however for some reason the nixpkgs version has a WM Class of "heroic".EDIT: It's alwaysheroic, but for some reason this doesn't cause issues for the flatpak version.This subtle discrepancy results in the app's window not being associated with its desktop entry, so it cannot be pinned, does not have an icon, etc.
Without this PR:
With this PR:
Note
It's also possible that the upstream WM Class is wrong, and it has gone unnoticed for whatever reason. I'll update this once I'm able to verify.
EDIT: upstream PR Heroic-Games-Launcher/HeroicGamesLauncher#4181
cc @aidalgol
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.