datasette: fix failing app on aarch64-darwin #367389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
lucasew
reviewed
Dec 22, 2024
ShaddyDC
approved these changes
Jan 14, 2025
Contributor
ShaddyDC
left a comment
ShaddyDC
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the issue for me on linux and the binary runs again.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367389
x86_64-linux
✅ 12 packages built:
- datasette (python312Packages.datasette)
- datasette.dist (python312Packages.datasette.dist)
- python311Packages.datasette
- python311Packages.datasette-publish-fly
- python311Packages.datasette-publish-fly.dist
- python311Packages.datasette-template-sql
- python311Packages.datasette-template-sql.dist
- python311Packages.datasette.dist
- python312Packages.datasette-publish-fly
- python312Packages.datasette-publish-fly.dist
- python312Packages.datasette-template-sql
- python312Packages.datasette-template-sql.dist
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5084 |
wegank
added
the
12.approvals: 1
Contributor
Author
|
Hi @wegank -- is this just waiting on the queued darwin tests at this point? Or is the |
Member
|
I guess there just aren't enough committers available. This PR LGTM, in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367388
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.