Skip to content

Comments

nixos/codeberg-pages: init#370864

Closed
NotAShelf wants to merge 2 commits intoNixOS:masterfrom
NotAShelf:nixos-codeberg-pages
Closed

nixos/codeberg-pages: init#370864
NotAShelf wants to merge 2 commits intoNixOS:masterfrom
NotAShelf:nixos-codeberg-pages

Conversation

@NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Jan 4, 2025 •
edited
Loading

Adds a NixOS module for Codeberg Pages. Still a bit rough around the edges, but should be ready for a review.

Draft for now as I intend to add a test soon, and go over security settings again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NotAShelf NotAShelf marked this pull request as draft January 4, 2025 14:24
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 4, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch 2 times, most recently from 7bc54cf to 1c785db Compare January 4, 2025 14:27
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 4, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from 1c785db to 85a6380 Compare January 4, 2025 14:36
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 4, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from 85a6380 to 739cb34 Compare January 4, 2025 14:47
@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 4, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from 739cb34 to e8ecf8a Compare January 4, 2025 17:38
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from e8ecf8a to 16dab4e Compare February 13, 2025 18:05
@NotAShelf NotAShelf closed this Mar 17, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from 16dab4e to 1701d8c Compare March 17, 2025 15:29
@NotAShelf
Copy link
Member Author

NotAShelf commented Mar 17, 2025

god dammit

@NotAShelf
Copy link
Member Author

NotAShelf commented Mar 17, 2025

Re-open sesamme

@NotAShelf NotAShelf reopened this Mar 17, 2025
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch 2 times, most recently from 96b516e to 5313488 Compare March 17, 2025 16:04
@NotAShelf NotAShelf force-pushed the nixos-codeberg-pages branch from 5313488 to bd4048c Compare March 28, 2025 00:13
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-24.11 labels Mar 28, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@NotAShelf
Copy link
Member Author

NotAShelf commented Apr 3, 2025 •
edited
Loading

The merge conflict is unmanagable, I'll continue in another PR.

Edit: continued in #395725

@NotAShelf NotAShelf closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NotAShelf @wegank @h7x4 @philiptaron