Skip to content

Conversation

@blackheaven
Copy link
Contributor

I've added rust-streamdeck, a CLI used to managed Elgato decks

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch from 8d8992e to 2dee42b Compare January 5, 2025 23:13
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 5, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Can you add a versionCheckHook? It basically runs the binary with a flag and checks basically if the version is in the output.

It's for basic checking of runtime failures.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371284


x86_64-linux

✅ 1 package built:
  • rust-streamdeck

@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch from 2dee42b to b283a88 Compare January 6, 2025 18:22
@blackheaven
Copy link
Contributor Author

Can you add a versionCheckHook? It basically runs the binary with a flag and checks basically if the version is in the output.

It's for basic checking of runtime failures.

it ignores meta.mainProgram:

rust-streamdeck> Running phase: installCheckPhase
rust-streamdeck> Executing versionCheckPhase
rust-streamdeck> versionCheckHook: /nix/store/8jnpbq3789zf11nik08mq6hibyf06f38-rust-streamdeck-0.9.0/bin/rust-streamdeck was not found, or is not an executable

@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch 2 times, most recently from 3cefc84 to 18fc984 Compare January 6, 2025 18:28
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Can you add a versionCheckHook? It basically runs the binary with a flag and checks basically if the version is in the output.
It's for basic checking of runtime failures.

it ignores meta.mainProgram:

rust-streamdeck> Running phase: installCheckPhase
rust-streamdeck> Executing versionCheckPhase
rust-streamdeck> versionCheckHook: /nix/store/8jnpbq3789zf11nik08mq6hibyf06f38-rust-streamdeck-0.9.0/bin/rust-streamdeck was not found, or is not an executable

versionCheckProgram from https://nixos.org/manual/nixpkgs/stable/#versioncheckhook

@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch from 18fc984 to 643eff3 Compare January 6, 2025 20:37
@blackheaven
Copy link
Contributor Author

Thanks, I've done it!

@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371284


x86_64-linux

✅ 1 package built:
  • rust-streamdeck

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask upstream to include a Cargo.lock. We try to avoid including lockfiles in nixpkgs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Comment on lines 37 to 38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir -p $out/lib/udev/rules.d
cp $src/40-streamdeck.rules $out/lib/udev/rules.d/
install -Dm444 40-streamdeck.rules -t $out/lib/udev/rules.d/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch from 643eff3 to 82a57b5 Compare March 11, 2025 18:49
@github-actions github-actions bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Mar 11, 2025
@blackheaven blackheaven force-pushed the rust-streamdeck/init-0.9.0 branch from 82a57b5 to fd244e3 Compare April 15, 2025 16:37
@Aleksanaa Aleksanaa merged commit cdf08d0 into NixOS:master Apr 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants