Conversation
|
This is mostly #335653 , with a few modifications:
|
|
I'll have a look at this later, I am happy to also be added to the maintainers field for the module. |
|
👍 Only changed the maintainer because I wasn't sure you were still up for it. Unfortunately I pulled at a thread and discovered that this module is not working correctly. Configuration changes get lost when the service is restarted - it's loading I've put up a PR for this issue here: hargata/lubelog#781 |
|
Putting this on hold until 1.4.3 comes out - it's going to remove the need to mix read-only and read-write paths. |
c5f56a3 to
fa41375
Compare
Check out #375887 and let me know what you think |
fa41375 to
c455022
Compare
|
This is ready to go. |
|
I think we should have a line in the 25.04 release notes for this |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2218 |
There was a problem hiding this comment.
Does it matter if localhost resolves to ipv4 or ipv6?
There was a problem hiding this comment.
On my system curl '[::1]:5000' and curl 127.0.0.1:5000 both work.
There was a problem hiding this comment.
When
localhostis specified, Kestrel attempts to bind to both IPv4 and IPv6 loopback interfaces.
Lyndeno
left a comment
There was a problem hiding this comment.
I agree with Sandro's suggestions
|
Is there anything else I can do to support this? Would be great to see this in the 25.05 release. |
|
Thanks for the push - updated. |
|
@SuperSandro2000 is there anything else needed to get this through? |
|
Rebased & moved the release notes to 25.11. |
|
LGTM |
|
I would like to have both this PR and #453649 make it into NixOS 25.11, giving us LubeLogger 1.5.4 and an associated module to run it. |
MattSturgeon
left a comment
There was a problem hiding this comment.
I have not tested anything, but LGTM.
6fc0769 to
8b46cc4
Compare
8b46cc4 to
bbab9f5
Compare
MattSturgeon
left a comment
There was a problem hiding this comment.
Sorry, I think #371458 (comment) got misinterpreted slightly?
bbab9f5 to
99f53db
Compare
MattSturgeon
left a comment
There was a problem hiding this comment.
There are a couple minor things I should've spotted in my earlier review. Still LGTM otherwise.
99f53db to
8cbcf5b
Compare
Adds a module for LubeLogger, and adds myself as maintainer.
Closes #333954
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.