freebsd.init: set mainProgram #371715
Merged
freebsd.init: set mainProgram #371715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
JohnRTitor
approved these changes
Jan 7, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Could you reformat it with nixfmt-rfc-style?
And just curious, why does this and other freebsd only packages use mkDerivation instead of stdenv.mkDerivation?
Contributor
Author
|
freebsd.mkDerivation builds programs that are resident in the freebsd src monorepo. I had some issues using the recent update of nixfmt-rfc-style 😓 I'll try again tomorrow. |
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
JohnRTitor
force-pushed
the
freebsd-init-mainprogram
branch
from
f64b7c0 to
acbbc3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cute little QoL fix :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.